feat: auto-migrate in-app wallets to enclave system #5217

joaquim-verges · 2024-10-29T07:34:28Z

Problem solved

PR-Codex overview

This PR focuses on enhancing the wallet migration process within the thirdweb package, specifically transitioning in-app wallets to a new enclave system, improving error handling, and refining wallet initialization logic.

Detailed summary

Added automatic migration for in-app wallets to the new enclave system.
Improved error handling in PassKeyLogin.tsx by logging errors.
Simplified condition for wallet generation in iframe-auth.ts.
Enhanced wallet migration logic in native-connector.ts with error logging.
Refined wallet initialization process in web-connector.ts, ensuring proper handling of wallet types.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-10-29T07:34:31Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 2:52am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 2:52am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 2:52am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 2:52am

changeset-bot · 2024-10-29T07:34:32Z

🦋 Changeset detected

Latest commit: 0cc8b40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
thirdweb	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

graphite-app · 2024-10-29T07:34:33Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

joaquim-verges · 2024-10-29T07:34:50Z

feat: auto-migrate in-app wallets to enclave system #5217 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite

github-actions · 2024-10-29T07:38:11Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	43 KB (0%)	861 ms (0%)	205 ms (+40.73% 🔺)	1.1 s
thirdweb (cjs)	103 KB (0%)	2.1 s (0%)	292 ms (+1.33% 🔺)	2.4 s
thirdweb (minimal + tree-shaking)	4.85 KB (0%)	97 ms (0%)	28 ms (-6.58% 🔽)	125 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	29 ms (+217.65% 🔺)	39 ms
thirdweb/react (minimal + tree-shaking)	17.51 KB (0%)	351 ms (0%)	155 ms (+307.33% 🔺)	505 ms

codecov · 2024-10-29T07:41:19Z

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 45.61%. Comparing base (9fb2a71) to head (0cc8b40).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...irdweb/src/wallets/in-app/web/lib/web-connector.ts	0.00%	12 Missing ⚠️
...dweb/src/react/web/wallets/shared/PassKeyLogin.tsx	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5217      +/-   ##
==========================================
- Coverage   45.61%   45.61%   -0.01%     
==========================================
  Files        1068     1068              
  Lines       55556    55557       +1     
  Branches     4047     4045       -2     
==========================================
  Hits        25341    25341              
- Misses      29525    29526       +1     
  Partials      690      690

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 9fb2a71
packages	`40.72% <0.00%> (-0.01%)`	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...dweb/src/react/web/wallets/shared/PassKeyLogin.tsx	`0.88% <0.00%> (-0.01%)`	⬇️
...irdweb/src/wallets/in-app/web/lib/web-connector.ts	`0.28% <0.00%> (ø)`

joaquim-verges marked this pull request as ready for review October 29, 2024 07:34

joaquim-verges requested review from MananTank, edwardysun, gregfromstl and jnsdls as code owners October 29, 2024 07:34

github-actions bot added the packages label Oct 29, 2024

joaquim-verges requested a review from ElasticBottle October 29, 2024 07:35

joaquim-verges added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Oct 29, 2024 — with Graphite App

vercel bot deployed to Preview – wallet-ui October 29, 2024 07:37 View deployment

vercel bot deployed to Preview – thirdweb_playground October 29, 2024 07:37 View deployment

vercel bot deployed to Preview – thirdweb-www October 29, 2024 07:45 View deployment

vercel bot deployed to Preview – docs-v2 October 29, 2024 07:47 View deployment

joaquim-verges force-pushed the feat_auto-migrate_in-app_wallets_to_enclave_system branch from 1d7f81e to 976e61c Compare October 29, 2024 23:59

vercel bot deployed to Preview – wallet-ui October 30, 2024 00:01 View deployment

vercel bot deployed to Preview – thirdweb_playground October 30, 2024 00:02 View deployment

vercel bot deployed to Preview – thirdweb-www October 30, 2024 00:09 View deployment

vercel bot deployed to Preview – docs-v2 October 30, 2024 00:10 View deployment

gregfromstl assigned joaquim-verges Nov 4, 2024

feat: auto-migrate in-app wallets to enclave system

0cc8b40

joaquim-verges force-pushed the feat_auto-migrate_in-app_wallets_to_enclave_system branch from 976e61c to 0cc8b40 Compare November 6, 2024 02:39

vercel bot deployed to Preview – wallet-ui November 6, 2024 02:42 View deployment

vercel bot deployed to Preview – thirdweb_playground November 6, 2024 02:43 View deployment

vercel bot deployed to Preview – docs-v2 November 6, 2024 02:46 View deployment

vercel bot deployed to Preview – thirdweb-www November 6, 2024 02:52 View deployment

joaquim-verges removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Nov 6, 2024

joaquim-verges merged commit b633293 into main Nov 6, 2024
31 of 33 checks passed

joaquim-verges deleted the feat_auto-migrate_in-app_wallets_to_enclave_system branch November 6, 2024 06:12

jnsdls mentioned this pull request Nov 6, 2024

Version Packages #5310

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: auto-migrate in-app wallets to enclave system #5217

feat: auto-migrate in-app wallets to enclave system #5217

Uh oh!

joaquim-verges commented Oct 29, 2024 •

edited

Loading

Uh oh!

vercel bot commented Oct 29, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 29, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 29, 2024

Uh oh!

joaquim-verges commented Oct 29, 2024

Uh oh!

github-actions bot commented Oct 29, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 29, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat: auto-migrate in-app wallets to enclave system #5217

feat: auto-migrate in-app wallets to enclave system #5217

Uh oh!

Conversation

joaquim-verges commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

graphite-app bot commented Oct 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

joaquim-verges commented Oct 29, 2024

Uh oh!

github-actions bot commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joaquim-verges commented Oct 29, 2024 •

edited

Loading

vercel bot commented Oct 29, 2024 •

edited

Loading

changeset-bot bot commented Oct 29, 2024 •

edited

Loading

github-actions bot commented Oct 29, 2024 •

edited

Loading

codecov bot commented Oct 29, 2024 •

edited

Loading